[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] memory: use a MemoryListener for core mem
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] memory: use a MemoryListener for core memory map updates too |
Date: |
Thu, 09 Feb 2012 11:28:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 |
On 02/09/2012 09:58 AM, Paolo Bonzini wrote:
> On 02/08/2012 04:27 PM, Avi Kivity wrote:
>> +static void core_log_stop(MemoryListener *listener,
>> + MemoryRegionSection *section)
>> +{
>> +}
>> +
>> +static void core_log_sync(MemoryListener *listener,
>> + MemoryRegionSection *section)
>> +{
>> +}
>> +
>
> Why not wrapping the calls inside an "if" so that these dummy
> functions need not be there? Can be done in a follow-up, though.
I dislike that style. We could have memory.c provide default versions
for users to put into their listener structures.
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH 05/10] memory: code motion: move MEMORY_LISTENER_CALL(), (continued)
- [Qemu-devel] [PATCH 05/10] memory: code motion: move MEMORY_LISTENER_CALL(), Avi Kivity, 2012/02/08
- [Qemu-devel] [PATCH 04/10] memory: switch memory listeners to a QTAILQ, Avi Kivity, 2012/02/08
- [Qemu-devel] [PATCH 02/10] memory: remove memory_region_set_offset(), Avi Kivity, 2012/02/08
- [Qemu-devel] [PATCH 03/10] memory: add shorthand for invoking a callback on all listeners, Avi Kivity, 2012/02/08
- [Qemu-devel] [PATCH 08/10] memory: don't pass ->readable attribute to cpu_register_physical_memory_log, Avi Kivity, 2012/02/08
- [Qemu-devel] [PATCH 07/10] memory: add a readonly attribute to MemoryRegionSection, Avi Kivity, 2012/02/08
- [Qemu-devel] [PATCH 01/10] ioport: change portio_list not to use memory_region_set_offset(), Avi Kivity, 2012/02/08
- [Qemu-devel] [PATCH 10/10] memory: drop AddressSpaceOps, Avi Kivity, 2012/02/08
- [Qemu-devel] [PATCH 09/10] memory: use a MemoryListener for core memory map updates too, Avi Kivity, 2012/02/08
- Re: [Qemu-devel] [PATCH 00/10] Remove AddressSpaceOps, Avi Kivity, 2012/02/08
- Re: [Qemu-devel] [PATCH 00/10] Remove AddressSpaceOps, Richard Henderson, 2012/02/08