Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after

[Andreas Färber]

Am 09.02.2012 13:34, schrieb Andreas Färber:
> Am 09.02.2012 13:15, schrieb Paul Brook:
>>> The ARM devboard models (vexpress-a9, realview, versatilepb, etc)
>>> were accidentally trying to set one of the arm_sysctl properties
>>> after device init. This has now become a fatal error; set the property
>>> before device init where it should be done instead.
>>>
>>> Signed-off-by: Peter Maydell <address@hidden>
>>> ---
>>> If somebody would like to commit this simple patch quickly that would
>>> probably be a good idea since these models are otherwise totally broken...
>>
>> Done.
> 
> Your commit should've contained Paolo's Reviewed-by tag after Peter's
> SoB, and you as committer didn't sign it off either.
> 
> http://git.qemu.org/?p=qemu.git;a=commit;h=7a65c8cc315c76bde6d692845c12e7ba06f44f89

...but it's nice that you aid in applying patches again. :)

> 
> Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg