Re: [Qemu-devel] sigaltstack bug in qemu (testing on qemu-ppc)

[Alexander Graf]

On 09.02.2012, at 19:36, Alex Barcelo wrote:

> On Sun, Feb 5, 2012 at 00:00, Peter Maydell <address@hidden> wrote:
>> On 4 February 2012 14:26, Alex Barcelo <address@hidden> wrote:
>>> (...)
>> This looks like a bug, yes -- the other architectures have the !
>> (or equivalent code) in their get_sigframe() implementations so
>> probably ppc is just wrong here.
> Yes, indeed. They do the check in some fancy ways (with a "!", with a
> "==0") but they all do the same.
> 
>> There are a few other architectures whose get_sigframe doesn't call
>> sas_ss_flags() at all -- they might also be wrong but I haven't checked.
> I checked some of them, and it seemed me correct because not all
> architectures have sigaltstack enabled. But I have not done a thorough
> check.
> 
> Just sent a trivial patch, hope is ok.

Thanks a lot for sending the patch out :). Please rework it according to the 
comments and I'll happily apply it.

Alex