|
| From: | Paul Brook |
| Subject: | Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h |
| Date: | Fri, 10 Feb 2012 00:26:40 +0000 |
| User-agent: | KMail/1.13.7 (Linux/3.1.0-1-amd64; KDE/4.6.5; x86_64; ; ) |
> There is no reason why the minimum timeout should be 1sec, it could > easily be 1h and we would save lots of cpu cycles. No. The reason we have this is because there are bits of code that rely on polling. IIRC slirp and the floppy DMA engine were the main culprits. qemu_calculate_timeout is an ugly hack to poll at least once a second, allowing the guest to make forward progress when we miss an event. If you think you've fixed all those polling places then you should remove the timeout altogether and block indefinitely. A 1h timeout is almost certainly not the right answer. Paul
| [Prev in Thread] | Current Thread | [Next in Thread] |