Re: [Qemu-devel] [PATCH v3 03/11] trace: [tracetool] Simplify event line parsing

[Harsh Bora]

On 02/10/2012 05:19 PM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova<address@hidden>
> ---
>   scripts/tracetool.py |   51 +++++++++++++++++++-------------------------------
>   1 files changed, 19 insertions(+), 32 deletions(-)
>
> diff --git a/scripts/tracetool.py b/scripts/tracetool.py
> index 7042728..549a90e 100755
> --- a/scripts/tracetool.py
> +++ b/scripts/tracetool.py

[...]

>   # A trace event
> +import re
> +cre = re.compile("(?P<name>[^(\s]+)\((?P<args>[^)]*)\)\s*(?P<fmt>\".*)?")
> +
>   class Event(object):
>       def __init__(self, num, line):
>           self.num = num
> -        self.args = get_args(line)
> +        m = cre.match(line)
> +        assert m is not None
> +        groups = m.groupdict('')
> +        self.args = groups["args"]
>           self.arglist = self.args.split(',')
> -        self.name = get_name(line)
> -        self.argc = get_argc(line)
> -        self.argnames = get_argnames(line)
> -        self.sizestr = calc_sizeofargs(line)
> -        self.fmt = get_fmt(line)
> +        self.name = groups["name"]
> +        if len(self.arglist) == 1 and self.arglist[0] == "void":
> +            self.argc = 0
> +        else:
> +            self.argc = len(self.arglist)

> +        if self.name == "slavio_misc_update_irq_raise":
> +            sys.stderr.write("%s : %d" % (self.name, self.argc))

I guess above 2 statements were added for debugging ^ ?

Harsh
> +        self.argnames = get_argnames(self.args)
> +        self.sizestr = calc_sizeofargs(self.args, self.argc)
> +        self.fmt = groups["fmt"]
>
>   # Generator that yields Event objects given a trace-events file object
>   def read_events(fobj):