[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum |
Date: |
Sat, 11 Feb 2012 13:45:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-02-11 12:46, Andreas Färber wrote:
> Am 10.02.2012 19:31, schrieb Jan Kiszka:
>> Always add a byte before the final 512-bytes alignment to reserve the
>> space for the ROM checksum.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>> pc-bios/optionrom/optionrom.h | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h
>> index aa783de..3daf7da 100644
>> --- a/pc-bios/optionrom/optionrom.h
>> +++ b/pc-bios/optionrom/optionrom.h
>> @@ -124,7 +124,8 @@
>> movw %ax, %ds;
>>
>> #define OPTION_ROM_END \
>> - .align 512, 0; \
>> + .byte 0; \
>> + .align 512, 0; \
>
> Tabs.
For sure, like in the whole file.
If a codestyle fix is desired, I'll post one for all assembly files. But
I guess there are different views on such changes.
Jan
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v2 3/8] target-i386: Add infrastructure for reporting TPR MMIO accesses, Jan Kiszka, 2012/02/10
[Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once, Jan Kiszka, 2012/02/10