Re: [Qemu-devel] [RFC Patch 3/7]Qemu: Cmd "block_set_hostcache" for dynamic cache change

[Supriya Kannery]

On 02/08/2012 05:37 PM, Luiz Capitulino wrote:
> On Wed, 01 Feb 2012 08:36:41 +0530
> Supriya Kannery<address@hidden>  wrote:

> > +    ret = bdrv_open(bs, bs->filename, bdrv_flags, drv);
> > +    if (ret<  0) {
> > +        /* Reopen failed. Try to open with original flags */
> > +        qerror_report(QERR_REOPEN_FILE_FAILED, bs->filename);
>
> OPEN_FILE_FAILED is fine.

ok

> > +/*
> > + * Change host page cache setting while guest is running.
> > +*/
> > +int do_block_set_hostcache(Monitor *mon, const QDict *qdict,
> > +                           QObject **ret_data)
>
> This is not a QAPI command, please read docs/writing-qmp-commands.txt to know
> how to write QMP commands using the QAPI.

fine, will check the doc

-thanks, Supriya