[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] [m68k] Move helpers.h to helper.h
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [PATCH] [m68k] Move helpers.h to helper.h |
Date: |
Mon, 13 Feb 2012 18:01:47 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) |
Andreas Färber writes:
> Am 13.02.2012 16:33, schrieb Lluís Vilanova:
>> Provides a file naming scheme consistent with other targets.
>>
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---
>> target-m68k/helper.c | 2 +-
>> target-m68k/helper.h | 54
>> +++++++++++++++++++++++++++++++++++++++++++++++
>> target-m68k/helpers.h | 54
>> -----------------------------------------------
>> target-m68k/op_helper.c | 2 +-
>> target-m68k/translate.c | 6 +++--
>> 5 files changed, 59 insertions(+), 59 deletions(-)
>> create mode 100644 target-m68k/helper.h
>> delete mode 100644 target-m68k/helpers.h
> Please check your git options, it did not recognize that you're renaming
> the file. Or did you also reformat it?
It's pure file renaming. Which git options are you referring to?
> Is there any particular reason for these three patches beyond
> aesthetics? Header names are purely target-specific choices here and do
> not simplify, e.g., any Makefile logic.
It's used by a tracetool-related patch in my TCG tracing queue. I just thought I
could send it separately (due to aesthetics) while other earlier patches are
waiting on enter Stefan's tracing queue.
Lluis
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth