[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h |
Date: |
Tue, 14 Feb 2012 10:52:53 +0000 |
User-agent: |
KMail/1.13.7 (Linux/3.1.0-1-amd64; KDE/4.6.5; x86_64; ; ) |
> Yes, you are right. Also considering that we are only calling
> slirp_update_timeout if CONFIG_SLIRP is defined, there is no need for
> the !CONFIG_SLIRP dummy version of the function.
Looks reasonable to me. Unfortunately I can't remember which combination of
headless VM and timer configs caused hangs when this was originally added.
If anyone has a setup that suffered timeout-related hangs last time we made
this change, please retest with this patch. Otherwise I guess we apply the
patch and hope we didn't miss anything.
> Author: Stefano Stabellini <address@hidden>
> Date: Mon Feb 13 11:25:03 2012 +0000
>
> main_loop_wait: block indefinitely
>
> - remove qemu_calculate_timeout;
>
> - explicitly size timeout to uint32_t;
>
> - introduce slirp_update_timeout;
>
> - pass NULL as timeout argument to select in case timeout is the
> maximum value;
>
> Signed-off-by: Stefano Stabellini <address@hidden>
Acked-by: Paul Brook <address@hidden>
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, (continued)
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Paolo Bonzini, 2012/02/10
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Paul Brook, 2012/02/10
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Paolo Bonzini, 2012/02/10
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Paul Brook, 2012/02/10
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Stefano Stabellini, 2012/02/10
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Paolo Bonzini, 2012/02/10
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Jan Kiszka, 2012/02/10
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Stefano Stabellini, 2012/02/10
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Paul Brook, 2012/02/10
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Stefano Stabellini, 2012/02/13
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h,
Paul Brook <=
- Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h, Stefano Stabellini, 2012/02/14