[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation |
Date: |
Tue, 14 Feb 2012 16:27:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 |
Am 06.02.2012 22:29, schrieb Hervé Poussineau:
> Here are misc fixes done by VirtualBox team.
> With these patches, floppy emulation is now good enough to run Xenix.
>
> Changes v3->v4:
> - added pc-1.1 machine type
> - disable media transfer rate check on older machine types
> - save/restore media transfer rate when media transfer rate check enabled
>
> Changes v2->v3:
> - removed patch changing controller stepping to 0
> - fixed out of bound access after bad seek command
>
> Changes v1->v2:
> - updated commit messages
> - added missing 'break' and braces
>
> Hervé Poussineau (11):
> fdc: take side count into account
> fdc: set busy bit when starting a command
> fdc: most control commands do not generate interrupts
> fdc: handle read-only floppies (abort early on write commands)
> fdc: add CCR (Configuration Control Register) write register
> block: add a transfer rate for floppy types
> pc: add 1.1 machine type
> fdc: add a 'check media rate' property. Not used yet
> fdc: check if media rate is correct before doing any transfer
> fdc: fix seek command, which shouldn't check tracks
> fdc: DIR (Digital Input Register) should return status of current
> drive...
>
> block.c | 74 ++++++++++++++++--------------
> block.h | 10 ++++-
> hw/fdc.c | 142
> +++++++++++++++++++++++++++++++++++++++++++++++-----------
> hw/pc.c | 3 +-
> hw/pc_piix.c | 47 +++++++++++++++++++-
> 5 files changed, 211 insertions(+), 65 deletions(-)
Thanks. I applied patches 1-5, 10 and 11 to the block branch, i.e.
leaving out the transfer rate stuff. I believe this is fairly
independent so it makes sense to apply the rest of the series without
it, but if you think I should dequeue all of the patches, let me know.
The main reason for not applying 6-9 is that I think migration is
broken, but I'll wait for Juan and/or Paolo to confirm. If a respin is
required, you can also fix the three default machine types.
Kevin