Re: [Qemu-devel] [RFC][PATCH 16/16 v6] allow user to dump a fraction of the memory

[Jan Kiszka]

On 2012-02-09 04:34, Wen Congyang wrote:
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index a026905..388b9ac 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -868,9 +868,11 @@ ETEXI
> 
>      {
>          .name       = "dump",
> -        .args_type  = "detach:-d,file:s",
> +        .args_type  = "detach:-d,file:s,begin:i?,length:i?",
>          .params     = "file",

You forgot to update params.

> -        .help       = "dump to file (using -d to not wait for completion)",
> +        .help       = "dump to file (using -d to not wait for completion)"
> +                      "\n\t\t\t begin(optional): the starting physical 
> address"
> +                      "\n\t\t\t length(optional): the memory size, in bytes",

Is it [begin [lenght]] or [begin lenght]? If you specify params, you
don't need to state optional here.

Same for QMP.

I'm short on time, thus didn't look at code in patches >= 10.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux