[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to d
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors |
|
Date: |
Wed, 15 Feb 2012 10:02:54 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-02-10 20:31, Luiz Capitulino wrote:
> The Monitor object is passed back and forth within the migration/savevm
> code so that it can print errors and progress to the user.
>
> However, that approach assumes a HMP monitor, being completely invalid
> in QMP.
>
> This commit drops almost every single usage of the Monitor object, all
> monitor_printf() calls have been converted into DPRINTF() ones.
Particularly NACK on this. Either the information is useless anyway,
then remove it. Otherwise, keep it for channels that can properly
display it (AKA HMP). I bet the latter can easily be achieved by
providing non-printing Monitor objects over QMP instances.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
[Qemu-devel] [PATCH 6/6] qapi: Convert migrate, Luiz Capitulino, 2012/02/10
Re: [Qemu-devel] [PATCH 6/6] qapi: Convert migrate, Jan Kiszka, 2012/02/15