Re: [Qemu-devel] [PATCH] i386: Remove REGPARM

[Blue Swirl]

On Wed, Feb 15, 2012 at 19:36, Richard Henderson <address@hidden> wrote:
> On 02/15/2012 10:11 AM, Blue Swirl wrote:
>>  #if defined(CONFIG_SOFTMMU)
>> -    int mem_index, s_bits, arg_idx;
>> +    int mem_index, s_bits;
>> +#if TCG_TARGET_REG_BITS == 64
>> +    int arg_idx;
>> +#else
>> +    int stack_adjust;
>> +#endif
>
> ...
>
>> -    if (TCG_TARGET_REG_BITS == 64) {
>> -        tcg_out_mov(s, (opc == 3 ? TCG_TYPE_I64 : TCG_TYPE_I32),
> ...
>> +#if TCG_TARGET_REG_BITS == 32
>> +    tcg_out_pushi(s, mem_index);
>
> Any particular reason you didn't continue with the C-if form,
> so that you could avoid the extra ifdeffery at the top there?

This code was copied from AREG0 version and there the path for 32 bit
version was not the same. Makes indeed sense here.