[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] arm: switch real-time clocks to rtc_clock
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] arm: switch real-time clocks to rtc_clock |
Date: |
Fri, 17 Feb 2012 09:31:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 |
On 02/17/2012 09:24 AM, andrzej zaborowski wrote:
>> > Ok, then I think it's better to switch that one to vm_clock (so that you
>> > could use it as a deterministic debugging aid with -icount, for
>> > example). What do you think?
> I was thinking about potential visual effects.
vm_clock is the same as rt_clock as long as: 1) you don't use -icount;
2) you don't stop the VM.
Not pulsing the LED when the VM is stopped seems okay, so I think
switching from rt_clock to vm_clock is the right thing to do.
> But perhaps you were
> right with the first approach, i.e. debugging -> deterministic (which
> in this case would ideally also use the frequency derived from the
> system clock passed to omap_lpg_init), normal work -> realtime.
You should get this from -icount if you just use vm_clock.
The overall series doesn't apply anymore, I'll split omap_lpg into its
own patch and resend.
Paolo