qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing
Date: Fri, 17 Feb 2012 11:42:56 +0200
User-agent: Mutt/1.5.21 (2010-09-15) 
On Thu, Feb 16, 2012 at 11:23:40PM +0400, malc wrote:
> > +{
> > +    unsigned dom, bus, slot, func;
> > +    int n = -1;
> > +
> > +    /* Parse [[<domain>:]<bus>:]<slot> */
> > +    sscanf(addr, "%x:%x:%x%n", &dom, &bus, &slot, &n);
> 
> sscanf can fail.
> 
> > +    if (n == -1) {


If it does n will stay -1.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]