[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device |
|
Date: |
Fri, 17 Feb 2012 14:25:56 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.26) Gecko/20120130 Red Hat/3.1.18-1.el6_2 Thunderbird/3.1.18 |
Hi,
> + /* If we don't specify the name, the bus will be addressed as <id>.0,
> where
> + * id is the parent id. But it seems more natural to address the bus
> using
> + * the parent device name. */
> + if (dev->qdev.id && *dev->qdev.id) {
> + br->bus_name = dev->qdev.id;
> + }
That makes the bridge behave different than everybody else.
Not a good idea IMHO.
cheers,
Gerd
[Qemu-devel] [PATCHv2-RFC 1/2] shpc: standard hot plug controller, Michael S. Tsirkin, 2012/02/13