[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/1] exec: Fix watchpoint implementation
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/1] exec: Fix watchpoint implementation |
Date: |
Fri, 17 Feb 2012 17:28:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-02-17 17:23, Meador Inge wrote:
> Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f
> where 'watch_mem_write' was modified to fall-through to 'abort' on
> every input.
>
> Signed-off-by: Meador Inge <address@hidden>
> ---
> exec.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index b81677a..fe8b2d1 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -3289,9 +3289,9 @@ static void watch_mem_write(void *opaque,
> target_phys_addr_t addr,
> {
> check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WRITE);
> switch (size) {
> - case 1: stb_phys(addr, val);
> - case 2: stw_phys(addr, val);
> - case 4: stl_phys(addr, val);
> + case 1: return stb_phys(addr, val);
> + case 2: return stw_phys(addr, val);
> + case 4: return stl_phys(addr, val);
> default: abort();
> }
> }
You likely wanted to introduce breaks here, no...?
At this chance, please indent the code properly according to our coding
style:
switch ...
case ...
xxx;
break;
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux