qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw/qxl: allow vram to be sized to 4096 bytes


From: Alon Levy
Subject: Re: [Qemu-devel] [PATCH] hw/qxl: allow vram to be sized to 4096 bytes
Date: Fri, 17 Feb 2012 21:15:57 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Feb 17, 2012 at 04:11:59PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > -    if (qxl->vram_size < 16 * 1024 * 1024) {
> > +    /* a request of 0 vram_size is translated to the smallest vram that 
> > doesn't
> > +     * break current off screen surfaces using drivers */
> > +    if (qxl->vram_size > 0 && qxl->vram_size < 16 * 1024 * 1024) {
> 
> Is there any reason to keep the 16MB minimum size?  I think we can just
> drop it and simplify the logic here.  See the patch series just sent.

I agree. Will review your patchset.

> 
> cheers,
>   Gerd
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]