qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/2] qxl: introduce QXLCookie


From: Alon Levy
Subject: Re: [Qemu-devel] [PATCH v2 1/2] qxl: introduce QXLCookie
Date: Fri, 17 Feb 2012 21:21:05 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Feb 17, 2012 at 09:09:11PM +0200, Alon Levy wrote:
> On Fri, Feb 17, 2012 at 01:49:20PM +0100, Marc-André Lureau wrote:
> > Hi
> > 
> > On Fri, Feb 17, 2012 at 9:44 AM, Alon Levy <address@hidden> wrote:
> > > +/* called from spice server thread context only */
> > > +static void interface_async_complete(QXLInstance *sin, uint64_t 
> > > cookie_token)
> > > +{
> > > +    PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl);
> > > +    QXLCookie *cookie = (QXLCookie*)cookie_token;
> > > +
> > > +    switch (cookie->type) {
> > 
> > We still have spice_qxl_flush_surfaces_async(&qxl->ssd.qxl, 0);
> > 
> > So cookie might be NULL in this case.
> 
> Yeah, Marc Andre also noticed (exprimentally - you take the cake on the
> review :).

Please ignore.

> 
> > 
> > -- 
> > Marc-André Lureau
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]