Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

[Blue Swirl]

On Sat, Feb 18, 2012 at 14:18, Anthony Liguori <address@hidden> wrote:
> On 02/18/2012 04:56 AM, Stefan Weil wrote:
>>
>> Am 18.02.2012 10:13, schrieb Blue Swirl:
>>>
>>> On Fri, Feb 17, 2012 at 15:26, Anthony Liguori <address@hidden>
>>> wrote:
>>>>
>>>> Well this was what I was getting at in my previous comments. If we just
>>>> need to reindent < 10 files with a few random changes here and there,
>>>> then
>>>> maybe that isn't so bad.
>>>>
>>>> But if we have to touch every single file in the tree in a significant
>>>> way,
>>>> then no way is it justified.
>>>
>>>
>>> One way to handle this is gradual reformatting, every time when code
>>> is touched, only changes towards common CODING_STYLE are allowed.
>>> Small, contained reformatting patches should be also allowed, for
>>> example to adjust brace style in one file a time or to remove spaces
>>> at the end of line.
>>
>>
>> I'd appreciate it very much if we could remove spaces at line endings
>> for all non binary files as soon as possible.
>
>
> Why?
>
> I really can't understand this.  It's not visible so it does no harm.

It's not the end of the world, but they could be mangled (which will
make patches fail to apply) when mailed and they waste precious bytes.
They are also not useful in any way, so better remove them.

> Regards,
>
> Anthony Liguori