Re: [Qemu-devel] [PATCH] block: fix block I/O throtting with IDE

[Zhi Yong Wu]

On Sun, Feb 19, 2012 at 11:40 PM, Andreas Färber <address@hidden> wrote:
> Am 19.02.2012 16:16, schrieb address@hidden:
>> From: Zhi Yong Wu <address@hidden>
>>
>> The patch is based on the latest QEMU upstream. If you will backport the 
>> patchset to QEMU 1.0, pls note the difference.
>
> "Fix" is never a good patch description. ;) In place of the above
> sentence, which does not tell us what the actual difference is, please
> describe in which way it was broken before and what the patch changes.
nice ,thinks.
>
> And if this is to be fixed on stable-1.0, please cc qemu-stable.
This is not for stable-1.0
>
> Andreas
>
>>
>> Signed-off-by: Zhi Yong Wu <address@hidden>
>> ---
>>  block.c |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/block.c b/block.c
>> index ae297bb..07cd143 100644
>> --- a/block.c
>> +++ b/block.c
>> @@ -863,6 +863,12 @@ void bdrv_drain_all(void)
>>  {
>>      BlockDriverState *bs;
>>
>> +    QTAILQ_FOREACH(bs, &bdrv_states, list) {
>> +        if (!qemu_co_queue_empty(&bs->throttled_reqs)) {
>> +            qemu_co_queue_restart_all(&bs->throttled_reqs);
>> +        }
>> +    }
>> +
>>      qemu_aio_flush();
>>
>>      /* If requests are still pending there is a bug somewhere */
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



-- 
Regards,

Zhi Yong Wu