Re: [Qemu-devel] [Spice-devel] [PATCH 4/4] [experimental] add optinal 64bit vram bar to qxl

[Alon Levy]

On Mon, Feb 20, 2012 at 09:00:14AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > I guess you will s/4/QXL_VRAM64_RANGE_INDEX/ when you send the
> > spice-protocol patch?
> 
> Yes.
> 
> >> -    if (qxl->vram_size < 4096) {
> >> -        qxl->vram_size = 4096;
> >> +    if (qxl->vram_size < qxl->vram32_size) {
> >> +        qxl->vram_size = qxl->vram32_size;
> > 
> > Am I reading correctly that you want the 64bit bar to be at least the
> > size of the 32bit bar? why?
> 
> The 64bit bar isn't additional memory.  Both 32bit and 64bit bar are
> backed by the same memory, the 64bit bar is just a different way to
> access it.  So it doesn't make sense at all to make the 64bit bar
> smaller than the 32bit bar.  The other way around makes sense, to save
> address space below 4G.

Ok, thanks for the patient repetition of your clear commit message :)

ACK

> 
> cheers,
>   Gerd
>