Re: [Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load()

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> This is used to sync the physical tray state after migration when
> using CD-ROM passthrough. However, migrating when using passthrough
> is broken anyway and shouldn't be supported...
>
> So, drop this function as it causes a problem with the DEVICE_TRAY_MOVED
> event, which is going to be introduced by the next commit.

I added ide_tray_state_post_load() mostly to satisfy an urge to always
call bdrv_eject() when tray_state changes, not because it's actually
useful.  I'm fine with dropping it.  Perhaps preventing migration while
the host CD-ROM is passed through would be even better.