[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 6/9] qxl: remove flipped
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RFC v4 6/9] qxl: remove flipped |
Date: |
Wed, 22 Feb 2012 15:09:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120210 Thunderbird/10.0.1 |
On 02/22/12 13:28, Alon Levy wrote:
> On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote:
>> Hi,
>>
>> It's not obvious to me how the non-flipped case (qxl_stride > 0) is
>> handled now. Have you tested this with both windows+linux guests?
>
> It isn't handled. The simplest way is just to if on the stride and do a
> single memcpy instead of individual line memcpy.
Single memcpy works only for full scanlines. qxl_flip can be extended
to handle both cases (and should probably also renamed then).
> This of course means we
> are doing a redundant copy,
No. You can wrap the qxl_flip call into ...
if (is_shared_buffer()) { ... }.
... to skip the copy if it isn't needed.
> since using our own DisplayAllocator or just
> the existing deallocate + our own allocate of ds->surface->data removes
> one copy.
I would just do
if (qxl_stride > 0) {
qemu_free_displaysurface
qemu_create_displaysurface_from
} else {
qemu_resize_displaysurface
}
cheers,
Gerd
- [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save, (continued)
- [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save, Alon Levy, 2012/02/21
- Re: [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save, Gerd Hoffmann, 2012/02/22
- Re: [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save, Alon Levy, 2012/02/22
- Re: [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save, Gerd Hoffmann, 2012/02/22
- Re: [Qemu-devel] [Spice-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save, Alon Levy, 2012/02/22
- Re: [Qemu-devel] [Spice-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save, Gerd Hoffmann, 2012/02/22
- Re: [Qemu-devel] [Spice-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save, Alon Levy, 2012/02/22
[Qemu-devel] [RFC v4 6/9] qxl: remove flipped, Alon Levy, 2012/02/21
[Qemu-devel] [RFC v4 7/9] qxl: introduce QXLCookie, Alon Levy, 2012/02/21
Re: [Qemu-devel] [Spice-devel] [RFC v4 0/9] qxl: fix hangs caused by qxl_render_update, Alon Levy, 2012/02/21
[Qemu-devel] [RFC v4 8/9] qxl: make qxl_render_update async, Alon Levy, 2012/02/21
[Qemu-devel] [RFC v4 9/9] qxl-render: call ppm_save on bh, Alon Levy, 2012/02/21