Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

[Andreas Färber]

Am 22.02.2012 16:42, schrieb Peter Maydell:
> On 22 February 2012 15:37, Andreas Färber <address@hidden> wrote:
>> NB: Your cpu-vmstate patches were not applied so far and they appear to
>> conflict with the plans we've made for redesigning cp15 on ARM: We want
>> to convert today's static fields to some list and were hoping to have a
>> mapping function for backwards compatibility. That works easiest in
>> imperative code.
> 
> I thought the idea for cp15 for vmstate was (like ppc) to basically
> have a uint32_t cp15_regs[512] which we save/load the whole of, and
> then the mapping function just assigns semantics to some subset
> of that array? vmstate can do a plain array without problems.

I thought we had concluded that the (3+3+4+4)² or so registers were too
large for that so that Alex suggested to leave the old load/save in
place (but getting/setting through a mapping function) and dynamically
appending only the new cp15 registers we don't have fields for yet when
some arrive. Or so I've understood.

I was planning some cp15 coding once I've moved some more stuff out of
CPU_COMMON and resolved the pxa270 CPU classes mess.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg