Re: [Qemu-devel] [PATCH 0/4] support to migrate with IPv6 address

[Kevin Wolf]

Am 10.02.2012 07:26, schrieb Amos Kong:
> Those four patches make migration of IPv6 address work.
> Use getaddrinfo() to socket addresses infomation.
> 
> ---
> 
> Amos Kong (4):
>       Use getaddrinfo for migration
>       net/socket: allow ipv6 for net_socket_listen_init and 
> socket_connect_init
>       net: split hostname and service by last colon
>       net: support to include ipv6 address by brackets

I think it would be better to split the patches differently:

1. Create tcp_server_start by moving code. Keep using parse_host_port
and the old loop around connect.
2. Unify all TCP servers to use this code
3. Introduce the client code and the convert all clients. Up to here,
this should be pure refactoring work.
4. Only now start changing the logic. First thing is getaddrinfo. Don't
change from IPv4 to IPv6 yet.
5. Make all changes required for IPv6 (getaddrinfo arguments, address
parsing, etc.)

Having step-by-step conversions with an explanation of each step in the
commit message makes it so much easier to understand the commits.

For the comments on details see the replies to the individual patches.

Kevin