[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrat
From: |
Federico Simoncelli |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands |
Date: |
Fri, 24 Feb 2012 07:12:27 -0500 (EST) |
----- Original Message -----
> From: "Kevin Wolf" <address@hidden>
> To: "Federico Simoncelli" <address@hidden>
> Cc: address@hidden, "Marcelo Tosatti" <address@hidden>, address@hidden,
> "Paolo Bonzini"
> <address@hidden>, "Markus Armbruster" <address@hidden>
> Sent: Friday, February 24, 2012 1:03:08 PM
> Subject: Re: [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands
>
> Am 24.02.2012 12:37, schrieb Federico Simoncelli:
> > Signed-off-by: Federico Simoncelli <address@hidden>
> > ---
> > block/blkmirror.c | 2 +-
> > blockdev.c | 109
> > +++++++++++++++++++++++++++++++++++++++++++++++------
> > hmp-commands.hx | 36 +++++++++++++++++
> > hmp.c | 30 ++++++++++++++
> > hmp.h | 2 +
> > qapi-schema.json | 63 ++++++++++++++++++++++++++++++
> > 6 files changed, 229 insertions(+), 13 deletions(-)
> >
> > diff --git a/block/blkmirror.c b/block/blkmirror.c
> > index 39927c8..49e3381 100644
> > --- a/block/blkmirror.c
> > +++ b/block/blkmirror.c
> > @@ -81,7 +81,7 @@ static int blkmirror_open(BlockDriverState *bs,
> > const char *filename, int flags)
> > bdrv_delete(m->bs[0]);
> > return -ENOMEM;
> > }
> > - ret = bdrv_open(m->bs[1], filename, flags, NULL);
> > + ret = bdrv_open(m->bs[1], filename, flags | BDRV_O_NO_BACKING,
> > NULL);
> > if (ret < 0) {
> > bdrv_delete(m->bs[0]);
> > return ret;
>
> Was this hunk meant to be in patch 1?
Not necessarily, I thought a lot about it. I didn't want to modify Marcelo's
patch too much. This flag is actually mandatory only to make blockdev-migrate
work with a destination that doesn't have a backing file yet, so I thought it
was more appropriate to squash it here.
--
Federico
- Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver, (continued)
Re: [Qemu-devel] Live Block Migration using Mirroring, Stefan Hajnoczi, 2012/02/23
Re: [Qemu-devel] Live Block Migration using Mirroring, Stefan Hajnoczi, 2012/02/23
[Qemu-devel] [PATCH 1/2] Add blkmirror block driver, Federico Simoncelli, 2012/02/24
[Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands, Federico Simoncelli, 2012/02/24
[Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver, Federico Simoncelli, 2012/02/24
[Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands, Federico Simoncelli, 2012/02/24