Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

[Luiz Capitulino]

On Fri, 24 Feb 2012 12:40:17 -0700
Eric Blake <address@hidden> wrote:

> On 02/24/2012 12:01 PM, Luiz Capitulino wrote:
> 
> >> +    BlockDriver *drv;
> >> +    int i, j, escape;
> >> +    char new_filename[2048], *filename;
> > 
> > I'd use PATH_MAX for new_filename's size.
> 
> PATH_MAX need not be defined (and on Hurd, it intentionally is not
> defined); or might be so huge as to be useless.

Aren't those extreme cases? PATH_MAX is a standard define and is used in
QEMU in several places. If it's not good here, it shouldn't be good anywhere.