[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vnc: Add break statement
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] vnc: Add break statement |
Date: |
Sat, 25 Feb 2012 16:57:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1 |
Am 25.02.2012 14:57, schrieb Stefan Weil:
> This was not a bug, but it is not common practice to omit the break statement
> from the last case statement before an empty default case.
>
> Any change of the default case would introduce a bug.
>
> This was reported as a warning by splint.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> ui/vnc-enc-hextile-template.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-template.h
> index b9f9f5e..a7310e1 100644
> --- a/ui/vnc-enc-hextile-template.h
> +++ b/ui/vnc-enc-hextile-template.h
> @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs,
> /* we really don't have to invalidate either the bg or fg
> but we've lost the old values. oh well. */
> }
> + break;
> default:
Doesn't that require a fallthrough comment for other tools then?
Andreas
> break;
> }
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg