Re: [Qemu-devel] [PATCH v2] w32: Support tests (make check)

[Stefan Weil]

Am 25.02.2012 17:31, schrieb Andreas Färber:
> Am 22.02.2012 20:48, schrieb Stefan Weil:
> > Adding $(EXESUF) is needed to make those tests work on w32 hosts, too.
> >
> > v2:
> > Rebased, added new tests, tests sorted alphabetically.
> >
> > Signed-off-by: Stefan Weil <address@hidden>
> > ---
> > tests/Makefile | 38 +++++++++++++++++++++++---------------
> > 1 files changed, 23 insertions(+), 15 deletions(-)
> >
> > diff --git a/tests/Makefile b/tests/Makefile
> > index 74b29dc..09f2b13 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -1,16 +1,24 @@
> > -CHECKS = check-qdict check-qfloat check-qint check-qstring check-qlist
> > -CHECKS += check-qjson test-qmp-output-visitor test-qmp-input-visitor
> > -CHECKS += test-string-input-visitor test-string-output-visitor 
> > test-coroutine
> > +CHECKS = check-qdict$(EXESUF)
> > +CHECKS += check-qfloat$(EXESUF)
> > +CHECKS += check-qint$(EXESUF)
> > +CHECKS += check-qjson$(EXESUF)
> > +CHECKS += check-qlist$(EXESUF)
> > +CHECKS += check-qstring$(EXESUF)
> > +CHECKS += test-coroutine$(EXESUF)
> > +CHECKS += test-qmp-input-visitor$(EXESUF)
> > +CHECKS += test-qmp-output-visitor$(EXESUF)
> > +CHECKS += test-string-input-visitor$(EXESUF)
> > +CHECKS += test-string-output-visitor$(EXESUF)
>
> Cute. (one-per-line allows to easily comment individual ones out)
>
> Some lines below were already way over 80 chars, so
>
> Reviewed-by: Andreas Färber <address@hidden>
>
> Andreas

And as long as they remain sorted, they also reduce the risk
of merge conflicts:

When everybody just adds to the end,two different commits
will always conflict.

They won't conflictif both commits add new lines at different
locations.

Regards,
Stefan