Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

[Andreas Färber]

Am 23.02.2012 16:34, schrieb Michael S. Tsirkin:
> On Tue, Feb 21, 2012 at 10:36:43AM +0100, Hannes Reinecke wrote:
>> diff --git a/hw/megasas.c b/hw/megasas.c
>> new file mode 100644
>> index 0000000..083c3d3
>> --- /dev/null
>> +++ b/hw/megasas.c

>> +static void megaraid1078_register_types(void)
>> +{
>> +    type_register_static(&megasas_info);
>> +}
>> +
>> +type_init(megaraid1078_register_types);
> 
> 
> why not megasas_ ?

And while at it, no semicolon after type_init() please. It defines a
function and I recently cleaned up all callers.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg