Re: [Qemu-devel] [PATCH v2 1/2] qapi: Introduce blockdev-group-snapshot-sync command

[Paolo Bonzini]

On 02/27/2012 04:46 PM, Kevin Wolf wrote:
> > +    /*
> > +     * Now we will drain, flush, & pivot everything - we are committed at 
> > this
> > +     * point.
> > +     */
> > +    bdrv_drain_all();
> 
> I would feel more comfortable if we could do the bdrv_drain_all() at the
> very beginning of the function. Not that I know of a specific scenario
> that would go wrong, but you have a nested main loop here that could do
> more or less anything.

The same could be said of a bdrv_read or a bdrv_write done by bdrv_open, no?

Paolo