[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/8] gtk: add support for screen scaling and ful
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 6/8] gtk: add support for screen scaling and full screen (v2) |
Date: |
Tue, 28 Feb 2012 15:18:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
Am 27.02.2012 21:10, schrieb Stefan Weil:
> Am 27.02.2012 00:46, schrieb Anthony Liguori:
>> Basic menu items to enter full screen mode and zoom in/out. Unlike SDL, we
>> don't allow arbitrary scaling based on window resizing. The current
>> behavior
>> with SDL causes a lot of problems for me.
>>
>> Sometimes I accidentally resize the window a tiny bit while trying to
>> move it
>> (Ubuntu's 1-pixel window decorations don't help here). After that,
>> scaling is
>> now active and if the screen changes size again, badness ensues since the
>> aspect ratio is skewed.
>>
>> Allowing zooming by 25% in and out should cover most use cases. We can
>> add a
>> more flexible scaling later but for now, I think this is a more friendly
>> behavior.
>>
>> Signed-off-by: Anthony Liguori <address@hidden>
>> ---
>> v1 -> v2
>> - fix scaling (Paolo)
>> - use ctrl-alt-+ instead of ctrl-alt-= for zoom
>> ---
>> ui/gtk.c | 92
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
>> 1 files changed, 88 insertions(+), 4 deletions(-)
>>
>> diff --git a/ui/gtk.c b/ui/gtk.c
>> index 0dac807..578cb94 100644
>> --- a/ui/gtk.c
>> +++ b/ui/gtk.c
>
> [...]
>
>>
>> + s->full_screen_item = gtk_check_menu_item_new_with_mnemonic("_Full
>> Screen");
>
> I suggest using the GTK standard widget GTK_STOCK_FULLSCREEN here.
> That's not a check menu item, so some more changes will be needed.
>
> Full screen mode does not need a check menu item, because you only
> see the menu item when it is not in full screen mode.
Tried Alt-V in full screen mode? ;-)
(Yes, I'd consider it a bug)
Kevin
- [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2), Anthony Liguori, 2012/02/26
- [Qemu-devel] [PATCH 1/8] console: allow VCs to be overridden by UI, Anthony Liguori, 2012/02/26
- [Qemu-devel] [PATCH 2/8] chr: check to see if front end has registered a read function, Anthony Liguori, 2012/02/26
- [Qemu-devel] [PATCH 4/8] gtk: add virtual console support (v2), Anthony Liguori, 2012/02/26
- [Qemu-devel] [PATCH 3/8] ui: add basic GTK gui (v2), Anthony Liguori, 2012/02/26
- [Qemu-devel] [PATCH 5/8] gtk: add support for input grabbing, Anthony Liguori, 2012/02/26
- [Qemu-devel] [PATCH 6/8] gtk: add support for screen scaling and full screen (v2), Anthony Liguori, 2012/02/26
- [Qemu-devel] [PATCH 7/8] gtk: add translation support, Anthony Liguori, 2012/02/26
- [Qemu-devel] [PATCH 8/8] gtk: make default UI, Anthony Liguori, 2012/02/26
- Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2), malc, 2012/02/27
- Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2), Jan Kiszka, 2012/02/27