[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] slirp: Fix requeuing of batchq packets in i
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] slirp: Fix requeuing of batchq packets in if_start |
Date: |
Wed, 29 Feb 2012 13:02:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-02-28 23:18, Stefan Weil wrote:
> Am 17.02.2012 16:45, schrieb Jan Kiszka:
>> In case we requeued a packet that was the head of a longer session
>> queue, we failed to restore this ordering. Also, we did not properly
>> deal with changes to Slirp::next_m.
>>
>> Instead of a cumbersome roll back, this fix simply avoids any changes
>> until we know if the packet was actually sent. Both fixes crashes due
>> to inconsistent queues and simplifies the logic.
>>
>> Thanks to Zhi Yong Wu who found the reason for these crashes.
>>
>> CC: Zhi Yong Wu <address@hidden>
>> CC: Fabien Chouteau <address@hidden>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>> slirp/if.c | 35 +++++++++++++++++++----------------
>> 1 files changed, 19 insertions(+), 16 deletions(-)
>
> Latest QEMU crashed here 4 times with MIPS Malta
> when I tried 'apt-get update' in the guest. See gdb output
> below for details.
>
> I only got the crash with big endian MIPS, not with little
> endian which is strange.
>
> After I reverted the above patch, MIPS Malta worked
> again as before.
>
> So maybe we changed one crash against a new one.
Could you retry with
git://git.kiszka.org/qemu.git queues/slirp
?
TIA,
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux