[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command
From: |
Michal Privoznik |
Subject: |
Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command |
Date: |
Wed, 29 Feb 2012 14:17:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120213 Thunderbird/10.0.1 |
On 28.02.2012 18:41, Luiz Capitulino wrote:
>> Hmm, I know Michal already sent a new version with my suggestions, but
>> > you're right, splitting out the commands simplified both the responses,
>> > and makes it easier to discover whether or not that information is
>> > available, since you can look for the command in guest-info before
>> > attempting it, rather than attempting it and then looking at the result.
>> >
>> > So maybe just something this?:
>> >
>> > { 'type': 'GuestNetworkInterface',
>> > 'data': { 'name': 'str',
>> > '*hardware-address': 'str',
>> > '*ip-addresses': ['GuestIpAddress'] } } }
>> >
>> > { 'command': 'guest-network-interfaces',
>> > 'returns': ['GuestNetworkInterface'] }
> Looks good to me, the only nitpick is that I think command names should be
> verbs.
guest-get-network-interfaces?
- [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command, Michal Privoznik, 2012/02/19
- Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command, Michal Privoznik, 2012/02/22
- Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command, Luiz Capitulino, 2012/02/23
- Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command, Michal Privoznik, 2012/02/27
- Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command, Michael Roth, 2012/02/27
- Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command, Luiz Capitulino, 2012/02/28
- Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command, Michael Roth, 2012/02/28
- Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command, Luiz Capitulino, 2012/02/28
- Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command,
Michal Privoznik <=
- Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command, Luiz Capitulino, 2012/02/29
- Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command, Michael Roth, 2012/02/29