Re: [Qemu-devel] [PATCH 2/3] Combine bdrv_aio_readv and bdrv_aio_writev into bdrv_aio_rw_vector

[Paolo Bonzini]

Il 29/02/2012 00:54, Michael Tokarev ha scritto:
> iscsi block driver may receive some additional work.  For now, some
> common code has been moved out of iscsi_aio_writev() and iscsi_aio_readv()
> into iscsi_aio_rw_vector().  Leftovers there can be optimized further,
> and consolidated into the rw_vector too.  Read and write callbacks are
> consolidated as well, and once the XXX "todo" bounce-buffer change is
> complete the only difference there should go away too.

What about flush, discard, etc.?

It seems to me that either we make a single entry point that takes some
kind of BlockRequest, or there is no reason to do partial unification.

Paolo