[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM
From: |
Wei Liu |
Subject: |
Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM |
Date: |
Thu, 1 Mar 2012 10:20:36 +0000 |
On Wed, 2012-02-29 at 17:47 +0000, Jan Kiszka wrote:
> On 2012-02-29 18:21, Wei Liu wrote:
> > Hi all
> >
> > This patch adds MSI / MSIX injection for Xen HVM guest. This is not new,
> > six months ago we had a discussion in
> > http://marc.info/?l=qemu-devel&m=130639451725966&w=2
>
> There are some coding style issues, please use checkpatch.pl.
>
Ah, looks like my Emacs messed it up...
> Back then I voted against "if (xen_enabled())" as I was planning for a
> msi injection hook that also Xen could use. That may change again, the
> final MSI layer design is not settled yet. Therefore, no concerns from
> that POV, this work takes longer. We can refactor the Xen hooks during
> that run again.
>
Right, Xen hook is relatively simple.
> However, you know that you miss those (uncommon) messages that are
> injected via DMA? They end up directly in apic_deliver_msi (where KVM
> will once pick them up as well).
>
Thanks for pointing this out. However I cannot find apic_deliver_msi in
qemu-kvm or upstream qemu tree. I can only find apic_send_msi and
apic_deliver_irq, none of which seems to be KVM-specific. Can you please
give me some pointer on this?
Wei.
- Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM,
Wei Liu <=
- Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM, Jan Kiszka, 2012/03/01
- Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM, Wei Liu, 2012/03/01
- Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM, Paolo Bonzini, 2012/03/01
- Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM, Stefano Stabellini, 2012/03/01
- Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM, Paolo Bonzini, 2012/03/01
- Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM, Stefano Stabellini, 2012/03/01
- Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM, Paolo Bonzini, 2012/03/01
- Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM, Stefano Stabellini, 2012/03/01