Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots

[Bobby Powers]

On Thu, Mar 1, 2012 at 12:08 PM, Eric Blake <address@hidden> wrote:
> On 03/01/2012 10:03 AM, Avi Kivity wrote:
>>>>
>>>> -    ram = memory_region_get_ram_ptr(mr) + section->offset_within_region;
>>>> +    ram = memory_region_get_ram_ptr(mr) + section->offset_within_region
>>>> + delta;
>>>
>>> Am I crazy, or does this look wrong?
>>
>> Could be both.  Why do you thing it is wrong?
>
> Line wrapping makes it look like we are adding two lines, one line
> ending in 'section->offset_within_region', and the next line starting
> with 'delta;', which is a syntax error.

yea, patch line wrapping was making my eyes see things.  okay, sorry
for the noise.

>
> But without line wrapping, we are adding just one line with
> 'offset_within_region + delta;' at the end of that line.
>
> --
> Eric Blake   address@hidden    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>