Re: [Qemu-devel] [PATCH 5/5] hw: add Atmel maxtouch touchscreen implementation

[Igor Mitsyanko]

On 03/02/2012 06:19 PM, Andreas Färber wrote:
> Hi Igor,
>
> Am 02.03.2012 12:35, schrieb Igor Mitsyanko:
> > diff --git a/Makefile.target b/Makefile.target
> > index 7968120..05ce652 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> > @@ -349,6 +349,7 @@ obj-arm-y += exynos4210_gic.o exynos4210_combiner.o 
> > exynos4210.o
> >   obj-arm-y += exynos4_boards.o exynos4210_uart.o exynos4210_pwm.o
> >   obj-arm-y += exynos4210_pmu.o exynos4210_mct.o exynos4210_fimd.o
> >   obj-arm-y += exynos4210_i2c.o exynos4210_gpio.o
> > +obj-arm-y += maxtouch.o
> >   obj-arm-y += arm_l2x0.o
> >   obj-arm-y += arm_mptimer.o a15mpcore.o
> >   obj-arm-y += armv7m.o armv7m_nvic.o stellaris.o pl022.o stellaris_enet.o
>
> I don't think this touchscreen device is really ARM-specific code-wise,
> is it? I would rather expect this to be hw-obj-$(CONFIG_MAXTOUCH) in
> Makefile.objs (so that it could be shared with, e.g., AVR).
> default-configs/arm-softmmu.mak would need CONFIG_MAXTOUCH=y then.
>
> Andreas
Sure, that makes a lot of sense.

Originally I was confused by framebuffer.o, bitbang_i2c.o (and a few 
other files) in arm-specific obj-arm-y. It gave me an impression that in 
case if only one target currently makes use of a certain hardware then 
corresponding hardware sources should be compiled only for this target.

--
Mitsyanko Igor
ASWG, Moscow R&D center, Samsung Electronics
email: address@hidden