Re: [Qemu-devel] [PATCH] spice: set spice uuid and name

[Alon Levy]

On Fri, Mar 02, 2012 at 01:49:22PM +0100, Marc-André Lureau wrote:
> This allows a Spice client to identify a VM

My only problem with this is that if we have a monitor vmcchannel you
could issue the command to query that, and much more, without having to
add any messages. And adding a monitor channel is really easy - the only
requirement being that qemu can handle two monitor users, libvirt and
spice.

> ---
>  ui/spice-core.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 1308a3d..8472cdd 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -19,6 +19,7 @@
>  #include <spice-experimental.h>
>  
>  #include <netdb.h>
> +#include "sysemu.h"
>  
>  #include "qemu-common.h"
>  #include "qemu-spice.h"
> @@ -699,6 +700,11 @@ void qemu_spice_init(void)
>  
>      qemu_opt_foreach(opts, add_channel, NULL, 0);
>  
> +#if SPICE_SERVER_VERSION >= 0x000a02 /* 0.10.2 */
> +    spice_server_set_name(spice_server, qemu_name);
> +    spice_server_set_uuid(spice_server, qemu_uuid);
> +#endif
> +
>      if (0 != spice_server_init(spice_server, &core_interface)) {
>          fprintf(stderr, "failed to initialize spice server");
>          exit(1);
> -- 
> 1.7.7.6
> 
>