Re: [Qemu-devel] [PATCH] Change library from libiscsi to libiscsiclient to match library rename in libiscsi

[Michael Tokarev]

On 03.03.2012 10:38, Ronnie Sahlberg wrote:
> Signed-off-by: Ronnie Sahlberg <address@hidden>
> ---
>  configure |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index fb0e18e..294c0c1 100755
> --- a/configure
> +++ b/configure
> @@ -2503,9 +2503,9 @@ if test "$libiscsi" != "no" ; then
>  #include <iscsi/iscsi.h>
>  int main(void) { iscsi_create_context(""); return 0; }
>  EOF
> -  if compile_prog "-Werror" "-liscsi" ; then
> +  if compile_prog "-Werror" "-liscsiclient" ; then
>      libiscsi="yes"
> -    LIBS="$LIBS -liscsi"
> +    LIBS="$LIBS -liscsiclient"
>    else
>      if test "$libiscsi" = "yes" ; then
>        feature_not_found "libiscsi"

Shouldn't we rename the feature and the --with/--without
name too here?  This appears to be partial "fix" for the
name change.

For the feature, I'd suggest using --with-iscsi instead of
--with-libiscsiclient.  But... dunno.

Thanks,

/mjt