Re: [Qemu-devel] [PATCH] make: remove generated objects from target dirs

[Michael S. Tsirkin]

On Sun, Mar 04, 2012 at 01:44:26PM +0000, Peter Maydell wrote:
> On 4 March 2012 13:31, Michael S. Tsirkin <address@hidden> wrote:
> > On Sun, Mar 04, 2012 at 01:25:59PM +0000, Peter Maydell wrote:
> >> In general we don't have workarounds for "something
> >> moved directory and this broke builds not from clean"
> >
> > Why don't we? It's cheaper than always doing
> > make clean after pull.
> 
> That's an argument for a general solution to the problem,
> not a one-off bandaid fix for the bit that happened to
> bite you.

What I did is generic: I remove all generated headers.
If you see more problems, let me know.

> >> (source file moved from hw/ to . being one that's bitten
> >> me before),
> >
> > Why would that bite anyone? AFAIK files under source control
> > are handled fine. It's the generated ones that are
> > a problem.
> 
> I forget the exact failure mode but I think the problem
> is that the old arm-softmmu/foo.d file is still lying
> around and claims that foo.o depends on the no-longer-present
> hw/foo.c. (If we didn't squash the directory structure, so
> that it was arm-softmmu/hw/foo.d and arm-softmmu/hw/foo.o,
> this problem wouldn't happen.)
> 
> -- PMM

Aha. A stale .d file, I see. Note that it's
siginificantly different from my problem. I would think if
.c is newer than .o we should just ignore .d,
alternatively make the dependencies in .d somehow weaker
than the implicit dependencies so they don't fail the build.
I'll see whether I can come up with a solution.

-- 
MST