Re: [Qemu-devel] [PATCH 5/6] cache-utils: Change data type of parameters for flush_icache_range

[Alexander Graf]

On 05.03.2012, at 21:07, Stefan Weil <address@hidden> wrote:

> Am 05.03.2012 19:57, schrieb Alexander Graf:
>> On 03/02/2012 11:30 PM, Stefan Weil wrote:
>>> The TCG targets i386 and tci needed a change of the function
>>> prototype for w64.
>>> 
>>> This change is currently not needed here, but it can be applied
>>> to avoid code differences.
>>> 
>>> Cc: Alexander Graf<address@hidden>
>>> Signed-off-by: Stefan Weil<address@hidden>
>>> ---
>>>  cache-utils.h |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>> 
>>> diff --git a/cache-utils.h b/cache-utils.h
>>> index 0b65907..04a6e2e 100644
>>> --- a/cache-utils.h
>>> +++ b/cache-utils.h
>>> @@ -12,7 +12,7 @@ extern struct qemu_cache_conf qemu_cache_conf;
>>>  void qemu_cache_utils_init(char **envp);
>>> 
>>>  /* mildly adjusted code from tcg-dyngen.c */
>>> -static inline void flush_icache_range(unsigned long start, unsigned long 
>>> stop)
>>> +static inline void flush_icache_range(uintptr_t start, uintptr_t stop)
>> 
>> Ugh, this causes compilation breakage:
>> 
>> CC cache-utils.o
>> In file included from cache-utils.c:1:
>> cache-utils.h:15: error: expected ‘)’ before ‘start’
>> make: *** [cache-utils.o] Error 1
>> 
>> because cache-utils.c doesn't include anything that would define uintptr_t. 
>> Any idea how to fix this?
>> 
>> 
>> Alex
> 
> 
> #include <stdint.h>

Mind to send a patch? ;)

Alex

> 
> Cheers,
> Stefan
> 
> 
>