[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 10/8] use QSIMPLEQ_FOREACH_SAFE when freeing list
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v3 10/8] use QSIMPLEQ_FOREACH_SAFE when freeing list elements |
Date: |
Tue, 6 Mar 2012 09:52:01 +0100 |
QSIMPLEQ_FOREACH will use the states pointer after the loop has freed it.
Signed-off-by: Paolo Bonzini <address@hidden>
---
Found while (re)reviewing Jeff's patches.
blockdev.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 1fb2a17..9480dbb 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -775,7 +775,7 @@ void qmp_transaction(BlockdevActionList *dev_list, Error
**errp)
{
int ret = 0;
BlockdevActionList *dev_entry = dev_list;
- BlkTransactionStates *states;
+ BlkTransactionStates *states, *next;
char *new_source = NULL;
QSIMPLEQ_HEAD(snap_bdrv_states, BlkTransactionStates) snap_bdrv_states;
@@ -926,7 +926,7 @@ delete_and_fail:
}
}
exit:
- QSIMPLEQ_FOREACH(states, &snap_bdrv_states, entry) {
+ QSIMPLEQ_FOREACH_SAFE(states, &snap_bdrv_states, entry, next) {
g_free(states);
}
g_free(new_source);
--
1.7.7.6
- Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions, (continued)
- [Qemu-devel] [PATCH v3 1/8] fix format name for backing file, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH v3 6/8] Add blkmirror block driver, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH v3 7/8] add mirroring to transaction, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH v3 4/8] add mode field to blockdev-snapshot-sync transaction item, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH v3 8/8] add drive-mirror command and HMP equivalent, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH v3 9/8] Add the drive-reopen command, Paolo Bonzini, 2012/03/06
- [Qemu-devel] [PATCH v3 10/8] use QSIMPLEQ_FOREACH_SAFE when freeing list elements,
Paolo Bonzini <=