[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: handle -EBUSY in bdrv_commit_all()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] block: handle -EBUSY in bdrv_commit_all() |
Date: |
Tue, 06 Mar 2012 11:01:18 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
Am 05.03.2012 19:10, schrieb Stefan Hajnoczi:
> Monitor operations that manipulate image files must not execute while a
> background job (like image streaming) is in progress. This prevents
> corruptions from happening when two pieces of code are manipulating the
> image file without knowledge of each other.
>
> The monitor "commit" command raises QERR_DEVICE_IN_USE when
> bdrv_commit() returns -EBUSY but "commit all" has no error handling.
> This is easy to fix, although note that we do not deliver a detailed
> error about which device was busy in the "commit all" case.
>
> Suggested-by: Kevin Wolf <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Thanks, applied to the block branch.
Kevin