[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features |
|
Date: |
Tue, 06 Mar 2012 15:59:53 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
Il 06/03/2012 15:55, Michael S. Tsirkin ha scritto:
> > It is not a problem if the destination does not have
> > VIRTIO_BALLOON_F_MUST_TELL_HOST. In that case, the guest
> > will simply do useless virtqueue traffic, but the destination
> > does not have a problem.
> > (In fact, it _is_ a problem if the destination has
> > VIRTIO_BALLOON_F_MUST_TELL_HOST but the source does not.
> > The feature bit should have been backwards! Luckily,
> > our implementation is free from this problem).
> >
> > Signed-off-by: Paolo Bonzini <address@hidden>
>
> Can't we just add a flag to control this feature?
I think the sane thing here would be to remove it from the spec.
Paolo
[Qemu-devel] [PATCH 1/3] virtio: let devices be permissive on enabled features, Paolo Bonzini, 2012/03/06