qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log
Date: Wed, 7 Mar 2012 17:08:41 +0000

On 7 March 2012 17:06, Eric Blake <address@hidden> wrote:
>>>  # Print a helpful header at the top of config.log
>>>  echo "# QEMU configure log $(date)" >> config.log
>>> -echo "# produced by $0 $*" >> config.log
>
> This left a trailing newline,
>
>>> +printf "# Configured with:" >> config.log
>>> +printf " '%s'" "$0" "$@" >> config.log
>
> but this does not.  You probably want to add another echo afterwards, so
> that the next line of the log doesn't look like another configure argument.

If you look at the whole change, rather than just the
fragment Stefan quoted to comment on:

 # Print a helpful header at the top of config.log
 echo "# QEMU configure log $(date)" >> config.log
-echo "# produced by $0 $*" >> config.log
+printf "# Configured with:" >> config.log
+printf " '%s'" "$0" "$@" >> config.log
+echo >> config.log
 echo "#" >> config.log

...you'll see that it does exactly what you suggest.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]