Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag

[Jason Baron]

On Wed, Mar 07, 2012 at 04:26:46PM -0500, Chris Metcalf wrote:
> On 3/7/2012 4:19 PM, Jason Baron wrote:
> > On Wed, Mar 07, 2012 at 11:43:02AM -0800, Roland McGrath wrote:
> >>> well, sure, we can provide an arch interface, for this check. I'm more
> >>> concerned with the general idea. If it seems ok, I can re-do this bit
> >>> with an arch interface.
> >> Anything based on strcmp is dismal.  VM_ALWAYSDUMP was nice and clean.
> >> A hook along the lines of arch_vma_name would be clean enough I suppose.
> >> In fact, there is only one instance today (tile) where 
> >> arch_vma_name()!=NULL
> >> wouldn't do just what you need.
> >>
> > Yeah, so I think something like the following would work (adding Tile
> > maintainer to 'cc list).
> 
> Thanks!
> 
> My instinct would be not to special-case it in always_dump_vma().  Since
> it's just a one-page region anyway, and it is at least potentially
> interesting, I'm happy to always dump it.  Alternately, we can just get rid
> of the "[intrpt]" name, which I just put in to be cute (and since it was
> easy to identify the mapping in question).  Regardless, since that region
> doesn't exist on our current 64-bit architecture, I'm not too concerned
> with how it's handled going forward, since I expect the 32-bit platform to
> become less popular over time.  I'd vote for generic code cleanliness.
> 

Ok, I'll just always dump it.

Thanks!

-Jason