qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io
Date: Fri, 09 Mar 2012 11:01:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1

Il 09/03/2012 06:01, David Gibson ha scritto:
> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to
> determine the direction of DMA it is emulating.  We already have a
> DMADirection enum designed specifically to encode DMA directions.
> This patch uses it for dma_bdrv_io() as well.  This involves removing
> the DMADirection definition from the #ifdef it was inside, but since that
> only existed to protect the definition of dma_addr_t from places where
> config.h is not included, there wasn't any reason for it to be there in
> the first place.

Looks good, but please use this for dma_buf_* too.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]