|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests |
Date: | Fri, 09 Mar 2012 06:04:23 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15 |
On 03/09/2012 05:20 AM, Cleber Rosa wrote:
You're comparing developer-level tests with the existent QA-level tests (much more complex).Let's be specific then. Look at device-add.sh in qemu-test. It's 71LOC. pci_hotplug.py in autotest is 204LOC.pci_hotplug.py does much more than device-add.sh: * tests both pci_add and device_add commands * checks the monitor syntax for adding a new drive, that is, it works on HEAD and on other versions (such as the ones in some RHEL releases); * tests both nic and block hotplug * for block, tests with both virtio and scsi * also does device removal, both for pci_add and device_add syntaxes
Ok, but clearly, there's no magic in autotest that makes this sufficiently easier. It's just a matter of:
cmd=`named_choose command device_add pci_add` if test $cmd = "device_add"; then qmp device_add --driver=virtio-blk-pci --drive=hd0 else hmp pci_add auto virtio-blk-pci,drive=hd0 fiIt's not there today because pci_add is deprecated. There assertion was that autotest makes it easier to write tests. How does it make it easier to write pci_hotplug?
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |